[go_router_builder] Adds name parameter to TypedGoRoute and supports its generation. #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd need a hand here, CI is failing because |
|
You need to separate out two pr, one for go_router and one for go_router_builder. The go_router one need to be merged first before the ci in go_router_builder can pass |
chunhtai
requested changes
Apr 10, 2023
11 tasks
dancamdev
changed the title
|
Needs #3702 to be merged before tests can pass and this pr can be merged. |
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
This PR is required for [#3665](#3665) to work and be merged. It should allow for generating `TypedGoRoutes` by defining a custom name and forwarding it to the underlying GoRoute. This is needed when working with Analytics services such as Google analytics that use the `RouteSettings.name` to log the page in their systems. *List which issues are fixed by this PR. You must list at least one issue.* [#120102](flutter/flutter#120102)
|
Hi @dancamdev, what's the status of this pr? |
Co-authored-by: MicheleBenedetti <Michele-x98@users.noreply.github.com>
2 tasks
chunhtai
reviewed
May 5, 2023
packages/go_router_builder/test/test_inputs/_go_router_builder_test_input.dart
Show resolved
Hide resolved
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
…upports its generation. (flutter/packages#3665)
11 tasks
camsim99
pushed a commit
to flutter/flutter
that referenced
this pull request
May 12, 2023
flutter/packages@0167d83...6328cfb 2023-05-10 43640732+dancamdev@users.noreply.github.com [go_router_builder] Adds name parameter to TypedGoRoute and supports its generation. (flutter/packages#3665) 2023-05-10 stuartmorgan@google.com [various] Remove iOS 9 references (flutter/packages#3948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
flutter/packages@0167d83...6328cfb 2023-05-10 43640732+dancamdev@users.noreply.github.com [go_router_builder] Adds name parameter to TypedGoRoute and supports its generation. (flutter/packages#3665) 2023-05-10 stuartmorgan@google.com [various] Remove iOS 9 references (flutter/packages#3948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
This PR is required for [flutter#3665](flutter#3665) to work and be merged. It should allow for generating `TypedGoRoutes` by defining a custom name and forwarding it to the underlying GoRoute. This is needed when working with Analytics services such as Google analytics that use the `RouteSettings.name` to log the page in their systems. *List which issues are fixed by this PR. You must list at least one issue.* [#120102](flutter/flutter#120102)
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…its generation. (flutter#3665) This PR allows for generating `TypedGoRoutes` by defining a custom name and forwarding it to the underlying `GoRoute` this is needed when working with Analytics services such as Google analytics that use the name to log the page in their systems. Fixes [#120102](flutter/flutter#120102)
11 tasks
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for generating
TypedGoRoutesby defining a custom name and forwarding it to the underlyingGoRoutethis is needed when working with Analytics services such as Google analytics that use the name to log the page in their systems.Fixes #120102
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.